Somebody using ofxPBRHelper with 0.10?

moebiussurfing · 2018-11-05 02:11:29 UTC

hey, I am trying to build ofxPBRHelper with several of the forks/branches (from ofxPBR too) without success.
I am getting several errors like:

/Users/myUser/Documents/openFrameworks/addons/ofxPBRHelper/03-geometryShaderExample/src/ofApp.cpp:11:19: Too few arguments to function call, expected at least 2, have 1
/Users/myUser/Documents/openFrameworks/addons/ofxPBR/src/ofxPBR.h:24:2: 'setup' declared here
/Users/myUser/Documents/openFrameworks/addons/ofxPBRHelper/03-geometryShaderExample/src/ofApp.cpp:38:9: No member named 'makeDepthMap' in 'ofxPBR'
/Users/myUser/Documents/openFrameworks/addons/ofxPBRHelper/03-geometryShaderExample/src/ofApp.cpp:43:25: Too many arguments to function call, expected 0, have 1
/Users/myUser/Documents/openFrameworks/addons/ofxPBR/src/ofxPBR.h:43:2: 'drawEnvironment' declared here
/Users/myUser/Documents/openFrameworks/addons/ofxPBRHelper/03-geometryShaderExample/src/ofApp.cpp:76:9: 'begin' is a private member of 'ofxPBR'
/Users/myUser/Documents/openFrameworks/addons/ofxPBR/src/ofxPBR.h:72:7: Declared private here
/Users/myUser/Documents/openFrameworks/addons/ofxPBRHelper/03-geometryShaderExample/src/ofApp.cpp:76:15: Too many arguments to function call, expected 0, have 2
/Users/myUser/Documents/openFrameworks/addons/ofxPBR/src/ofxPBR.h:72:2: 'begin' declared here
/Users/myUser/Documents/openFrameworks/addons/ofxPBRHelper/03-geometryShaderExample/src/ofApp.cpp:95:9: 'end' is a private member of 'ofxPBR'
/Users/myUser/Documents/openFrameworks/addons/ofxPBR/src/ofxPBR.h:73:7: Declared private here
/Users/myUser/Documents/openFrameworks/addons/ofxPBRHelper/03-geometryShaderExample/src/ofApp.cpp:97:9: 'begin' is a private member of 'ofxPBR'
/Users/myUser/Documents/openFrameworks/addons/ofxPBR/src/ofxPBR.h:72:7: Declared private here
/Users/myUser/Documents/openFrameworks/addons/ofxPBRHelper/03-geometryShaderExample/src/ofApp.cpp:97:15: Too many arguments to function call, expected 0, have 1
/Users/myUser/Documents/openFrameworks/addons/ofxPBR/src/ofxPBR.h:72:2: 'begin' declared here
/Users/myUser/Documents/openFrameworks/addons/ofxPBRHelper/03-geometryShaderExample/src/ofApp.cpp:101:9: 'end' is a private member of 'ofxPBR'

Any help about what versions/forks are working are appreciated.

hamoid · 2018-11-05 11:32:51 UTC

I tried by using https://github.com/neilmendoza/ofxPBR and https://github.com/neilmendoza/ofxPBRHelper and it worked. I did have to change two things though:

Find two instances of float GetOcclusion and make sure it returns 1.0 instead of 1 (float vs int).
In main.cpp, replace setting the width and height properties (now private) by settings.setSize(1280, 720);

Can you try with those two forks and see if it works for you?

note: I realized part of the changes I made are already implemented upstream.

moebiussurfing · 2018-11-05 19:32:09 UTC

Cool thanks a lot @hamoid ! It works like you say. (OF masterbranch, Xcode9, High Sierra) Int to Float change not was mandatory.

The only problem is that it crashes when clicking gui button to load change the texture or cubemap/panorama.:

This happens with ofxImgui both masterbranch or 1.62 release version…

hamoid · 2018-11-05 21:44:26 UTC

I see you were trying 04-vboMesh_InstancingExample. That one has a missing data/ofxPBRAssets/textures folder which you can copy from 03-geometryShaderExample.

Does that fix the issue?

moebiussurfing · 2018-11-06 01:42:38 UTC

that do not fixed the crash. I copied the textures folder. All the 4 examples are getting the same crash when clicking on this gui buttons.

hamoid · 2018-11-06 09:16:01 UTC

I see now that I’m using an old ofxImGui… In mine clicking the images do nothing, and in yours they crash. I’ll try to fix that.

Update: so if I update ofxImGui to the latest version I get the same crash as you do. It seems to happen here:

github.com

yasuhirohoshino/ofxPBRHelper/blob/master/src/ofxPBRHelper.cpp#L485


				// base color

				ImGui::Text("base color");

				ImTextureID baseColorId;

				if (material->baseColorMap != nullptr && material->baseColorMap->isAllocated()) {

					baseColorId = (ImTextureID)(uintptr_t)material->baseColorMap->getTextureData().textureID;

				}else{

					baseColorId = 0x0;

					material->enableBaseColorMap = false;

				}

				ImGui::PushID(0);

				if (ImGui::ImageButton(baseColorId, ImVec2(40, 40), ImVec2(0, 0), ImVec2(1, 1), 1.0)) {

					showTextureWindow = true;

					currentId = 0;

				}

				if (ImGui::BeginPopupContextItem("delete"))

				{

					if (ImGui::Button("Delete")) {

						ImGui::CloseCurrentPopup();

						material->enableBaseColorMap = false;

						material->baseColorMap = nullptr;

						params->baseColorTex = "";

I guess because it sets

showTextureWindow = true;

I guess there’s something wrong in this function

github.com

yasuhirohoshino/ofxPBRHelper/blob/master/src/ofxPBRHelper.cpp#L762


			textureLoaded = false;

		}



		if (texErase) {

			files->textures[eraseTexName]->clear();

			files->textures[eraseTexName] = nullptr;

			files->textures.erase(eraseTexName);

			texErase = false;

		}



		if (showTextureWindow) {

			if (materials.find(currentMaterialKey) != materials.end()) {

				ofxPBRMaterial* material = materials[currentMaterialKey].first;

				MaterialParams* params = &materials[currentMaterialKey].second;



ImGui::SetNextWindowSize(ImVec2(300, 150), ImGuiSetCond_FirstUseEver);

				ImGui::Begin("Textures", &showTextureWindow);

				if (ImGui::Button("load texture")) {

					ofFileDialogResult openFileResult = ofSystemLoadDialog("Select a image");

					if (openFileResult.bSuccess) {

						if (files->textures.find(openFileResult.getName()) == files->textures.end()) {

but I have no time to debug now… Maybe you could try commenting out the content of that function and add it back line by line until you figure out where it happens. The console is not showing anything useful, even in debug mode…

moebiussurfing · 2018-11-09 00:14:00 UTC

hey @hamoid, good news in the house
@yasuhiro0122 just made all the update work: