Semantic issues with glm::vec in OF from git

hamoid · November 26, 2019, 11:59am

I’m currently unable to compile simple programs as it is giving me errors in various core OF files, for example this:

openframeworks/openFrameworks/blob/master/libs/openFrameworks/gl/ofMaterial.h#L265




	mutable std::map<ofGLProgrammableRenderer*,std::shared_ptr<Shaders>> shaders;
	static std::map<ofGLProgrammableRenderer*, std::map<std::string,std::weak_ptr<Shaders>>> shadersMap;
	static std::string vertexShader;
	static std::string fragmentShader;
	std::map<std::string, float> uniforms1f;
	std::map<std::string, glm::vec2> uniforms2f;
	std::map<std::string, glm::vec3> uniforms3f;
	std::map<std::string, glm::vec4> uniforms4f;
	std::map<std::string, float> uniforms1i;
	std::map<std::string, glm::vec<2, int, glm::precision::defaultp>> uniforms2i;
	std::map<std::string, glm::vec<3, int, glm::precision::defaultp>> uniforms3i;
	std::map<std::string, glm::vec<4, int, glm::precision::defaultp>> uniforms4i;
	std::map<std::string, glm::mat4> uniforms4m;
	std::map<std::string, glm::mat3> uniforms3m;
	std::map<std::string, TextureUnifom> uniformstex;
};

Is that valid syntax? Is my compiler outdated?

/home/x/src/openFrameworks/libs/openFrameworks/math/ofVectorMath.h:125: error: ‘vec’ does not name a type; did you mean ‘sec’?
  inline std::ostream& operator<<(std::ostream& os, const vec<3, T, P>& vec) {
                                                          ^~~
                                                          sec

hamoid · November 26, 2019, 12:13pm

Ok, I just learned something. Fixed by running

$ download_libs.sh

again.

We could add a new point to https://github.com/openframeworks/openFrameworks/blob/master/INSTALL_FROM_GITHUB.md mentioning what steps are required when you pull changes from the repo one year later

arturo · November 26, 2019, 12:26pm

can you add send a PR adding that to the doc? it’s something that trips people up frequently

hamoid · November 26, 2019, 12:51pm

Yes. I’ll add a section “How to update openFrameworks from github”

As a first step, is git pull enough? Or do you need one of these for the submodules?

After pulling

download_dependencies.sh
download_libs.sh

Then install the Qt Creator - OF script (or equivalent for VS or XCode)

Those are the 4 required steps?

arturo · November 26, 2019, 1:54pm

we don’t update submodules that often from the main repo so the best way to keep the project generator up to date is to go in it’s folder and pull from master there too

hamoid · November 26, 2019, 1:56pm

That means

cd apps/projectGenerator
git pull

?

arturo · November 26, 2019, 1:59pm

yes or git pull upstream master

arturo · November 26, 2019, 2:00pm

but upstream depends on how everyone has configured git so perhaps git pull is less confusing