grabScreen

kizm_naoya · April 27, 2011, 3:46pm

hello.

I want to save screen image oh iphone.
the image file was created, but it is just black screen.
do you know what I need? initialization or something?

*condition*
iOS 4.2
xcode 3.2.4
openframeworks 0062

*testApp.h*

  
  
ofImage Img;

*testApp.mm*

  
  
Img.grabScreen( 0, 0, ofGetWidth(), ofGetHeight() );  
Img.saveImage( ofxiPhoneGetDocumentsDirectory() + "test.png" );

astellato · April 27, 2011, 5:31pm

  
ofxiPhoneScreenGrab(NULL);

kizm_naoya · April 28, 2011, 7:58pm

Thanks your reply, I checked but it’s same before…

astellato · April 29, 2011, 5:06pm

Hmm, that’s strange. ofxiPhoneScreenGrab uses glReadPixels to grab the screen. Are you using a modified version of OF? Maybe you could post your code for others to look at?

Akira_At_Asia · April 30, 2011, 12:38am

Hi there,

yes ofxiPhoneScreenGrab() works for me.
thanks astellato

For next step, i want to do

save screen data inside .app(not in the album),
play with saved screen pixels.

I tried ofxFBOTexture.getPixel(), ofImage.grabScreen(), ofTexture.loadScreenData(),
but none of them seems works.

So I wrote small function following astellato’s advice.
Named ofxiPhoneGrabScreenPix which returns raw screen pixel.

on ofxiPhoneExtras.h

  
unsigned char* ofxiPhoneGrabScreenPix(id delegate);

on ofxiPhoneExtras.mm

  
  
unsigned char* ofxiPhoneGrabScreenPix(id delegate) {  
	CGRect rect = [[UIScreen mainScreen] bounds];  
	int width = ofGetWidth();  
	int height =  ofGetHeight();	  
	  
	NSInteger myDataLength = width * height * 4;  
	unsigned char *buffer = (GLubyte *) malloc(myDataLength);  
	unsigned char *bufferFlipped = (GLubyte *) malloc(myDataLength);  
	glReadPixels(0, 0, width, height, GL_RGBA, GL_UNSIGNED_BYTE, buffer);  
	for(int y = 0; y <height; y++) {  
		for(int x = 0; x <width * 4; x++) {  
			bufferFlipped[int((height - 1 - y) * width * 4 + x)] = buffer[int(y * 4 * width + x)];  
		}  
	}  
	free(buffer);	// free original buffer  
	  
	return bufferFlipped;  
}

then in your testApp

  
  
img.setFromPixels(ofxiPhoneGrabScreenPix(ofxiPhoneGetAppDelegate()), ofGetWidth(), ofGetHeight(), OF_IMAGE_COLOR_ALPHA);

I know this is tricky(because i chagend core oF),
so I appreciate any other smart workaround

this is sample project
http://cl.ly/6LnH

***note***
I’m using 007 iphone+oF static lib grabbed from here
http://forum.openframeworks.cc/t/working-fork-of-git-iphone-version-with-retina-support/6050/0
Thank you Apex!

kizm_naoya · April 30, 2011, 6:27pm

Hi,

Your code works well on openframeworks 0062, thanks for your sample.

but it is better to modify a little.
because I need to modify a little for following setting.

  
  
ofxiPhoneSetOrientation(OFXIPHONE_ORIENTATION_LANDSCAPE_RIGHT);

anyway, thanks again!

nardove · July 24, 2011, 11:26am

Hi,

Does anyone have a working example in 007? Im using the code from the first post but nothing happens, not even an error message and no image at all.

Thanks

rS

lossless · July 24, 2011, 10:07pm

did you try astellato’s suggestion in the second post? i’m using 007 and it works for me: the screen is grabbed and saved to the photo album. fwiw, the code from the first post did not work for me in terms of saving to the photo album; i’m guessing it is saving it elsewhere, if at all.

nardove · August 3, 2011, 7:06pm

~~Not sure where to put that piece of code, any hints?~~

Never mind found my answer here http://forum.openframeworks.cc/t/screen-grab-on-iphone/4228/0

mantissa · August 30, 2011, 12:09am

it looks like ofImage.grabScreen() fails on the iPhone when you haven’t allocated it yet.

  
  
  
myImage.allocate(ofGetWidth(), ofGetHeight(), OF_IMAGE_COLOR_ALPHA);  
myImage.grabScreen(0, 0, ofGetWidth(), ofGetHeight());  
  
ofSetColor(255, 255, 255);  
myImage.draw(0, 0);

also - note that the image should be allocated using OF_IMAGE_COLOR_ALPHA.

not sure if this is still a problem in 007

momo_the_monster · November 28, 2011, 7:50pm

This method does not work with anti-aliasing turned on like this:
iOSWindow->enableAntiAliasing(4);

StephenBaker · November 28, 2011, 10:44pm

I’ve been battling this, too. There are a few GL functions that aren’t supported in GLES with multisampling / antialiasing, namely glReadPixels. I’ve found a couple of leads on binding an additional framebuffer without multisampling, but haven’t had any success yet only black frames.

http://stackoverflow.com/questions/765434/glreadpixels-from-fbo-fails-with-multisampling

If anyone has a solution let me know!

Thanks,
Steve

vgbnd · January 13, 2012, 2:15pm

i also desperately need to take a snapshot of a multi sampled renderer. after hours of searching the net for solutions i give up.

anyone lucky so far?

here’s what i tried:
https://gist.github.com/1606382

used apple’s code from http://developer.apple.com/library/ios/#qa/qa1704/-index.html (works fine without multisampling, stays black with AA)
tried to make sense of these two stackoverflow questions.

http://stackoverflow.com/questions/6869577/problem-in-reading-data-using-glreadpixel
http://stackoverflow.com/questions/7402504/multisampled-render-to-texture-in-ios

laserpilot · January 13, 2012, 10:51pm

having the exact same issue, but I’m not worried about antialiasing. I have the app set up to use retina display, but when i use this:

  
        ofxiPhoneAppDelegate * delegate = ofxiPhoneGetAppDelegate();    
        ofxiPhoneScreenGrab(delegate);

It had been taking an image of just 1/4 of the entire screen for some reason. My quick fix was to go to the ofxiPhoneScreenGrab method and multiply the width/height ints by 2 and it seems to come out correctly now…but there must be a more elegant way to do it than messing with the core

Lines I modified in ofxiPhoneScreenGrab:

  
void ofxiPhoneScreenGrab(id delegate) {  
	CGRect rect = [[UIScreen mainScreen] bounds];  
      
	int width = rect.size.width*2; //CHA-CHA-CHA-CHANGESSS  
	int height =  rect.size.height*2; //CHA-CHA-CHA-CHANGESSS  
	  
	NSInteger myDataLength = width * height * 4;

Also, does anyone know what decides the orientation of the taken screenshot? all of mine keep being portrait but I’m trying to get them to be landscape

cerupcat · January 14, 2012, 2:44am

Are you on a retina screen? Maybe the height and width needs to be x 2 since you’re on retina?

laserpilot · January 14, 2012, 5:33am

@Seth - right, my device does have a retina display but I don’t understand why it thinks it has a smaller window than it actually has. For my glsetup in main.mm it’s (iOsWindow,960,480,OF_FULLSCREEN) but I dont think i follow why it need to be doubled in that screengrab method

cerupcat · January 14, 2012, 6:55am

What happens if you put this in your main.mm

  
  ofAppiPhoneWindow * iOSWindow = new ofAppiPhoneWindow();      
    iOSWindow->enableRetinaSupport();          
    ofSetupOpenGL(iOSWindow, 480, 320, OF_FULLSCREEN);          
    ofRunApp(new testApp);

Jason Walters · January 14, 2012, 9:04pm

edit — laserpilot - this is how i solved the resolution isse… note my comments @JRW

opps i responded too quickly and didn’t realize you now want to adjust the orientation…

  
void ofxiPhoneScreenGrab(id delegate) {  
	CGRect rect = [[UIScreen mainScreen] bounds];  
      
    //JRW - Retina Fix for PhotoGrab  
    if ([[UIScreen mainScreen] respondsToSelector:@selector(scale)] == YES){  
		  
        float f_scale = [[UIScreen mainScreen] scale];  
          
        rect.size.width *= f_scale;  
        rect.size.height *= f_scale;  
    }  
      
	int width = rect.size.width;  
	int height =  rect.size.height;

jonano · March 13, 2012, 4:11pm

why not doing it like that?

  
void ofxiPhoneScreenGrab(id delegate) {  
    int width = ofGetWidth();  
    int height = ofGetHeight();

nardove · April 25, 2012, 10:20pm

@jasonwalters your solution works for me thanks a lot